Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify benchmark prepare bash path #1564

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

PerseidMeteor
Copy link
Contributor

correct the performance test prepare bash file path

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

image

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@PerseidMeteor PerseidMeteor requested a review from a team as a code owner March 26, 2024 01:53
@PerseidMeteor PerseidMeteor requested review from liubogithub, jiangliu and hsiangkao and removed request for a team March 26, 2024 01:53
1. correct the performance test prepare bash file path

Signed-off-by: YuQiang <[email protected]>
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.22%. Comparing base (9ae8e3a) to head (02129f2).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1564      +/-   ##
==========================================
- Coverage   61.23%   61.22%   -0.02%     
==========================================
  Files         144      144              
  Lines       47100    47100              
  Branches    44602    44602              
==========================================
- Hits        28843    28838       -5     
  Misses      16778    16778              
- Partials     1479     1484       +5     

see 2 files with indirect coverage changes

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@imeoer imeoer merged commit af914dd into dragonflyoss:master Mar 26, 2024
58 checks passed
@PerseidMeteor PerseidMeteor deleted the fix-performance-prepare branch March 26, 2024 02:06
@PerseidMeteor PerseidMeteor restored the fix-performance-prepare branch March 26, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants